search

themesberg / flowbite

Open-source UI component library and front-end development framework based on Tailwind CSS
https://flowbite.com
MIT License
7.31k stars 710 forks source link

Button size #794

Closed ArseniyXaoc closed 5 months ago

ArseniyXaoc commented 5 months ago

Describe the bug The height of the "Extra small" button on https://flowbite.com/docs/components/buttons/ is 32px, but in the DS template figma v 2.9.0 it is 34px

2024-02-02_14-15-27

2024-02-02_14-28-30

zoltanszogyenyi commented 5 months ago

Hey @ArseniyXaoc,

Thanks for reporting! @robert1508 is this correct? Should our buttons be smaller on the docs?

Cheers, Zoltan

robert1508 commented 5 months ago

Hello @ArseniyXaoc,

We use these classes both on Figma DS and in the code to build the buttons [py-2 px-3 text-xs font medium], and the font itself makes the button 2px taller when we code it.

As a reference, we always took the padding and font size and not the height, because in Figma we don't use a specific height but the classes for tailwind and font size.

Line height is also the normal one both on Figma and on the code, if we try to put "leading-tight" then the button comes out 31px.

zoltanszogyenyi commented 5 months ago

Closed until further notice.