themesberg / flowbite

Open-source UI component library and front-end development framework based on Tailwind CSS
https://flowbite.com
MIT License
7.66k stars 721 forks source link

`Dismiss` duration doesn't apply to transition. #924

Open gabrielso opened 2 months ago

gabrielso commented 2 months ago

Describe the bug When I set up a Dismiss object with the following options:

<div id="dismissMe">
  <p> Dismiss me! </p>
  <span id="dismissTrigger"> [X] </span>
</div>

<script>
  let dismiss = new Dismiss(document.querySelector("#dismissMe"), null, { duration: 10000 });
  document.querySelector("#dismissTrigger").addEventListener("click", (e) => { dismiss.hide() });
</script>

I expect that when clicking "[X]" the dismiss transition (default "transition-opacity") to follow the duration, the #dismissMe element opacity should slowly disappear, taking 10s to change from 1 to 0.

To Reproduce Steps to reproduce the behavior:

  1. Set up a Dismiss with the duration option set to 10000
  2. Trigger the .hide() function
  3. Note that the transition-opacity for the target element goes from 1 to 0 fast (assuming 300ms)
  4. Note that the target element block space is still present on the page for the remaining duration.
  5. After 10s (the duration option) the element is removed from the page, the block space previously occupied by the target element is removed.

Expected behavior I expect the transition to follow the duration option, the element opacity should slowly decrease in the 10s duration as set in the example.

Desktop (please complete the following information):

gabrielso commented 2 months ago

I assume the duration option must be one of the presets defined by Tailwind? If that's the case the documentation leaves much to be desired. I can submit a PR to add this note if that's the case.

However, even if I try to generate a custom duration in tailwind.config.js it doesn't work:

module.exports = {
  // ...
  theme: {
    extend: {
      transitionDuration: {
        '10000': '10s', // or '10000ms'
      }
    }
  }
}

I would like to be able to set custom durations and having them be applied regardless of Tailwind. Does that make sense?