themesberg / flowbite

Open-source UI component library and front-end development framework based on Tailwind CSS
https://flowbite.com
MIT License
7.98k stars 746 forks source link

fix the issue #973 #983

Closed Jameslebron6 closed 1 month ago

Jameslebron6 commented 1 month ago

Issue

WYSIWYG: When text is set to bold, it is not possible to change its color. #973

Pull Request Description

Summary This pull request addresses the issue #973 where, after applying bold formatting to text in the WYSIWYG editor, users were unable to change the color of the bolded text.

Changes Made

Updated the text formatting logic to allow color changes to be applied to bolded text. Ensured that the editor state correctly reflects both the bold and color attributes simultaneously.

Steps to Test

1.Open the WYSIWYG text editor. 2.Select some text and click the Bold button to apply bold formatting. 3.Then select the same text, click the Text Color button, and choose a color. 4.Verify that the text remains bold while the selected color is applied. 5.This fix ensures that users can now change the color of bold text without losing the bold formatting.

Outcome Screenshots

https://github.com/user-attachments/assets/d0124ac6-0fa8-4859-acb2-36c97004ed3a

Additional note

1.This modification allows the text font to change its color while being bold, fixing the previous bug

2.Please review the changes and let me know if any further modifications are needed.

Thank you for considering this update!

Jameslebron6 commented 1 month ago

Dear @zoltanszogyenyi Hi, I just improved the wysiwyg plugin page in the issue of #973: When text is set to bold, it is no longer possible to set a color for it. in PR #983. It would be thankful is you can review my PR and merge it.

Jameslebron6 commented 1 month ago

Original, it will show like the below Screenshots

https://github.com/user-attachments/assets/2681a9ef-68f2-48c3-b9e0-592077920992

zoltanszogyenyi commented 1 month ago

This is a good fix for an edge case. Thanks for contributing! <3