themesberg / volt-bootstrap-5-dashboard

Free and open source Bootstrap 5 Admin Dashboard Template with vanilla Javascript
https://themesberg.com/docs/volt-bootstrap-5-dashboard/getting-started/quick-start/
MIT License
2.62k stars 305 forks source link

RTL support #6

Closed zoltanszogyenyi closed 3 years ago

zoltanszogyenyi commented 4 years ago

RTL support.

AbdQaadir commented 4 years ago

Hello, @zoltanszogyenyi

I'd like to work on the issue raised here. This would be a great opportunity to contribute to open source and improve my skills.

zoltanszogyenyi commented 4 years ago

Hey @AbdQaadir,

That would be awesome! I think you also know Arabic, right? That would make it easier.

The way I suggest going forward is like this:

The RTL version should be built in a way that it is an extension of the current Sass files. I think we could create a "_rtl.scss" file and override certain Bootstrap 5 variables and custom classes (if needed, BS5 variables have priority) to make text, elements, sidebars, and so on be aligned in a proper way.

The extension styles should be written in a way that when Bootstrap 5 will be updated or we make style updates, that it will only minimally affect the RTL version. (probably some changes will need to be made for the RTL Sass/HTML files as well, but we should keep it to a minimum if possible).

Would you prefer me to prepare the structure of these files and the methodologies or would you like to start right away?

Ultimately it will become a sidebar element called "RTL version" and when clicked on it it will show the dashboard with RTL support.

Thanks for your contribution!

AbdQaadir commented 4 years ago

Yeah, I know a bit of Arabic.

I'd prefer you prepare the structure and methodologies.

zoltanszogyenyi commented 4 years ago

I'll let you know when it is ready then!

zoltanszogyenyi commented 3 years ago

Bootstrap 5 Beta 1 now brings official support for RTL, so this issue will be merged with this one: https://github.com/themesberg/volt-bootstrap-5-dashboard/issues/24