search

themeteorchef / base

A starting point for Meteor apps.
http://themeteorchef.com/base
MIT License
695 stars 253 forks source link

React Bootstrap ListGroupItem and Button component hrefs are resulting in page loads. #205

Closed PaulSavignano closed 7 years ago

PaulSavignano commented 7 years ago

The hrefs on React Bootstrap's ListGroupItem and Button components are currently resulting in page loads. Suggest a refactor to Link for Buttons and browserHistory.push() for ListGroupItems.

demyxco commented 7 years ago

Any update on this? I'm new to meteor and everything about this boilerplate.

PaulSavignano commented 7 years ago

Hi Cim, I submitted a pull request to correct the behavior. Each ListGroupItem needs an onClick handler pointing to a function that uses browserHistory.push() and the hrefs removed. The Buttons can be wrapped in a Link element from React Router.

Paul (760) 390-3534

On Thu, Dec 1, 2016 at 2:00 PM, Cim notifications@github.com wrote:

Any update on this? I'm new to meteor and everything about this boilerplate.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/themeteorchef/base/issues/205#issuecomment-264308866, or mute the thread https://github.com/notifications/unsubscribe-auth/ALL9GeBJtpOpZUZfhV3UGhKiULmJpOaSks5rD0NvgaJpZM4K89sp .

demyxco commented 7 years ago

Thanks for the update! I added your code to the plate and it works like it should.

PaulSavignano commented 7 years ago

Good to hear!

sergical commented 7 years ago

or React Router Bootstrap can be implemented :)

themeteorchef commented 7 years ago

Going to close this out as this is being merged in the next release :)