Open bcampardou opened 7 years ago
Hi @BaobabCoder thank you for taking the time to do this :) Going to review now.
@BaobabCoder there seems to be an issue with the new this.hideDelay
value being introduced.
It's referenced here but never defined anywhere else in the file. This is causing the alert to stay on screen until the user clicks (as expected when passing -1
), but if I pass a custom delay value like your example 3000
, the alert still displays indefinitely.
Can you take a look at this for me and let me know if I'm missing something? For reference, I used the two example calls in your comment above to test (both the advanced and standard versions).
sure ! I'll take a look as soon as possible. I'm sorry my tests passed.
@themeteorchef i've made a mistake. Fixed now :)
How does one close the alert manually? Is it by pressing anywhere on the bert message like normal? Do we or can we have a close button?
@bluefangs just clicking on the Bert closes it at the moment.
I did not add buttons. The feature "close on click" was already present
Is this repository dead ?
In a brief coma. Bert was poisoned while taking part in an experiment in which he consumed expired tofu for a month straight. He's currently showing signs of life and just recently mumbled "yoga" the other day. We're optimistic of his recovery :)
We believe in you Bert! You can do it!
@maxpdx
Simply disable the timer when
Bert.defaults.hideDelay = -1
for example.41 How can I keep bert alert on screen and manually close it?
Edit : with latest commit also fix #23 #37 #13
You can configure all alerts to be manually closed :
Bert.defaults.hideDelay = -1
or specify an alert to be manually closed by using :
or