search

themeteorchef / bert

A client side, multi-style alerts system for Meteor.
185 stars 27 forks source link

FIX:#58 - Bert not working as expected #60

Closed brucejo75 closed 4 years ago

brucejo75 commented 4 years ago

Fixes #58.

This PR fixes 2 issues, plus some bonus improvements.

  1. Fix the way the icons are changed so that bert can now work around @fortawesome/fontawesome#12552.
  2. Fix keeping the icons white.
  3. Add a #with directive so that the alert helper only needs to be called once (reducing the reactive cycling).
  4. Use a requestAnimationframe rather than waiting 20ms.
themeteorchef commented 4 years ago

Hey @brucejo75 thanks for putting this all together, really appreciate the help :) I'll take a look and get it merged.