themeum / kirki

Extending the customizer
https://kirki.org
MIT License
1.26k stars 328 forks source link

Editor issues #1594

Closed rthvanesa closed 7 years ago

rthvanesa commented 7 years ago

Issue description:

The issues appeared in 3.0.10 and haven't been solved in the latest version. The editor button doesn't close. And I also get duplicated content in different editors. The video below illustrates the issues ( tested with Kirki 3.0.11 ): https://s.nimbus.everhelper.me/share/1210559/h32ezm917w1gvm7aqxe8

Version used:

Kirki 3.0.9, 3.0.10, 3.0.11 and develop

Using theme_mods or options?

Theme mods

Code to reproduce the issue (config + field(s))

Kirki::add_config( 'my_theme', array(
   'capability'        => 'edit_theme_options',
   'option_type'       => 'theme_mod',
   'disable_output'    => true,
) );

Kirki::add_section( 'editor', array(
   'title'          => esc_attr__( 'Kirki Editor', 'mytheme' ),
   'priority'       => 10,
   'capability'     => 'edit_theme_options',
) );

Kirki::add_field( 'my_theme', array(
   'type'        => 'editor',
   'settings'    => 'editor1',
   'label'       => esc_attr__( 'Kirki Editor 1', 'mytheme' ),
   'section'     => 'editor',
   'default'     => '',
));

Kirki::add_field( 'my_theme', array(
   'type'        => 'editor',
   'settings'    => 'editor2',
   'label'       => esc_attr__( 'Kirki Editor 2', 'mytheme' ),
   'section'     => 'editor',
   'default'     => '',
));

Kirki::add_field( 'my_theme', array(
   'type'        => 'editor',
   'settings'    => 'editor3',
   'label'       => esc_attr__( 'Kirki Editor 3', 'mytheme' ),
   'section'     => 'editor',
   'default'     => '',
));

Kirki::add_field( 'my_theme', array(
   'type'        => 'editor',
   'settings'    => 'editor4',
   'label'       => esc_attr__( 'Kirki Editor 4', 'mytheme' ),
   'section'     => 'editor',
   'default'     => '',
));

Hope the issues will be solved. Thank you for support!

aristath commented 7 years ago

fixed in #1596, will be included in the next release.