search

themeum / kirki

Extending the customizer
https://kirki.org
MIT License
1.26k stars 329 forks source link

[CRITICAL] Textdomain issue when updating theme in WordPress repository #2518

Open mapsteps opened 10 months ago

mapsteps commented 10 months ago

Issue description:

Hey guys!

I've just noticed when updating Kirki to v5 in Page Builder Framework, an additional textdomain ('easy-digital-downloads') is being flagged when pushing to the WordPress repository.

It seems to be coming from the commit that merges the pro extensions into the free version - https://github.com/themeum/kirki/commit/fac009be1542324abff3e19b1c1c7257934d1698

For some reason, the file EDD_SL_Plugin_Updater.php was added which I think doesn't belong into the plugin at all.

image

We used to have the updater in the Kirki Pro Tabs (and others) in earlier commits when we were in charge of Kirki but removed those later on.

Looks to me that an older version of the Kirki Pro Tabs was merged into the free version and released with v5 (instead of the very latest master).

Can you please check?

Thank you! :)

Version used:

5.0

mapsteps commented 10 months ago

Did a quick comparison between our latest master & the version of Kirki Pro Tabs included in Kirki. From what I can tell, you only need to delete the edd folder and the EDD_SL_Plugin_Updater.php file included in it and we should be fine :)