themeum / qubely

Qubely Blocks – Full-fledged Gutenberg Toolkit
GNU General Public License v3.0
84 stars 36 forks source link

Conflict with OceanWP #31

Closed dovy closed 4 years ago

dovy commented 4 years ago

Suggestion: You're using a rather default CSS value for your qubely-sections:

<div class="wp-block-qubely-row alignfull qubely-section qubely-block-1ab7cd">
</div>

Other themes are also using the .alignfull class. I would suggest either prefixing with qubely, or doing a forced value on margin:

.qubely-section.alignfull {
    margin: 0;
}

Theme that causes such an issue: OceanWP, but you'll find it with more. Use unique classes to avoid collision.

fai-sal commented 4 years ago

hi @dovy, Good day!

We believe providing most flexible experiences with Qubely, therefore we have intentionally used the default CSS value of alignfull class of the active theme. However if users need to customize, they can add following code in any block inside Block Raw CSS option under Advanced Panel and that will solve the issue.

 .qubely-section.alignfull {
    margin: 0;
} 

image I hope that helps.

Regards, Faisal Ahmed

dovy commented 4 years ago

That's fine, but any users of the OceanWP theme are going to have extra margins. Just letting you know.

fai-sal commented 4 years ago

dear @dovy, Thank you so much for your concern, we really appreciate suggestions but in this case we would like to respect the theme CSS over ours as our ROW block explicitly has own Margin settings (inside Dimension Panel) and if users feel to overwrite the theme Margin, they can easily do so.

Screenshot 2020-03-23 at 10 30 09 AM

Once again thank you, stay safe and keep using Qubely!

Regards, Faisal Ahmed

dovy commented 4 years ago

That's fine. As long as you realize the 0 you have there is not accurate. How can they set the margin to 0 if your default SAYS it's 0. I'm not going to fight you on it. ;)