search

themeum / qubely

Qubely Blocks – Full-fledged Gutenberg Toolkit
GNU General Public License v3.0
84 stars 36 forks source link

Styles do not apply to reusable blocks #4

Closed vena closed 4 years ago

vena commented 4 years ago

When converting a Qubely block, for example tabs, to a reusable block, it loses styles and they don't carry over to other placements of the reusable block. This occurs with both header and filesystem style settings.

murshed commented 4 years ago

Hi,

When converting a Qubely block, for example tabs, to a reusable block, it loses styles and they don't carry over to other placements of the reusable block. This occurs with both header and filesystem style settings.

Thanks for the heads up! We will inform our devs

Also, I'll let you know after checking from my localhost.

Can you please help us to make a short video?

Thanks.

epakrat commented 4 years ago

Yes, this is still an issue in the Qubely Free Plugin v1.2.1

Running WP v5.2.4 with GeneratePress Free Theme and Gutenberg v6.8.0 Plugin on Windows 10 Laragon Localhost environment

Only the two plugins mentioned above were active during my testing.

What I did to reproduce the issue...

1) Create a Tab Block in the 'wp_block' ( Reusable Blocks Post Type). 2) Inserted into a page from the Reusable Block Category. 3) Viewing the page produces a visible / functional ( js appears like it loaded ) but completely unstyled ( CSS didn't get enqueued?) when Tab block is output on the front end.

What fixed the issue...

I clicked the vertical 3 dots menu and selected "Convert to Regular Block" and then inserted the Reusable version as well ( or in addition to ) so the two instances were in the same page. Since the "regular" one enqueues everything proper both then display fine. Very consistent / repeatable.

Interestingly, the CSS no longer fails after having been saved once with the "regular" version even after it has been deleted on that page and the "reusable" has been left alone as the only block in the content. Is this the result of static / inline styles being saved with the content instead of dynamically on page load? I would have expected it to revert to it's prior behavior instead of the actual behavior.

This happens regardless of the "CSS Save Method" in the options for every new page / post.

nicmare commented 4 years ago

i can confirm this!! most of the time styles to not apply. sometimes it works, sometimes not. especially when you use a reusable block which you created originally from out another page.

anik commented 4 years ago

I got the issue. You can import reusable block from here- http://prntscr.com/pv7mtg

Every CSS will word if you import from here. It's a temporary solution but works.

nicmare commented 4 years ago

No! This won't work either. Watch the complete video please: https://www.dropbox.com/s/50k1jq5oozncm1b/reusable-block.mov?dl=0 BTW: spacing does not work too… but i like the option. Would be nice to have it on each block. Not on layouts/reusable blocks only

anik commented 4 years ago

Re-Usable block is now fixed. This bug is now testing process and added with the core ASAP.

https://github.com/themeum/qubely/commit/f4137ec0c20a959d5c483253b980a2e67b6967c6

nicmare commented 4 years ago

not fixed 100%. in some cases it does not work: https://www.dropbox.com/s/ghc8jc9n736imtt/qubely-reusable-blocks.mov?dl=0 Sometimes if you make changes to the block itself what is the main purpose of this function…

anik commented 4 years ago

We fix it again. Here is the latest build- https://www.dropbox.com/s/x3ss3casrnmm3lm/qubely.zip?dl=0