search

themexpert / onepager

Onepage Theme/Website Builder for WordPress
https://themesgrove.com/wp-onepager/
Other
304 stars 101 forks source link

Switch from SweetAlert to SweetAlert2 #135

Closed limonte closed 6 years ago

limonte commented 6 years ago

I would like to propose to switch from SweetAlert to SweetAlert2 - the supported fork of SweetAlert. The original reason for creating SweetAlert2 is inactivity of SweetAlert: https://stackoverflow.com/a/27842854/1331425

Reasons to switch:

  1. Accessibility (WAI-ARIA) - SweetAlert2 is fully WAI-ARIA compatible and supports all popular screen-readers. Accessibility is a must in 2017, there are a lot of explanatory and tech articles, but this one is truly inspirable: Software development 450 words per minute

  2. Better buttons contrast is a huge advantage for all users especially for users with vision disabilities.

  3. Better support, average time to resolve an issue:

    • SweetAlert:
    • SweetAlert2:

  4. Implement FIXME in engine/meta.js

  5. SweetAlert2 is more popular that SweetAlert:

    • SweetAlert:
    • SweetAlert2:
limonte commented 6 years ago

ping

limonte commented 6 years ago

ping :)

limonte commented 6 years ago

ping

limonte commented 6 years ago

I guess this project is dead :(