search

themichaeltsang / clm_catkin-indigo

clm-facetracker support on ros-indigo, catkin-buildsystem
1 stars 1 forks source link

Improvements on the CLM ROS bridge #3

Closed alecive closed 8 years ago

alecive commented 8 years ago

Hey @themichaeltsang ,

I have made some improvements in the past week on the CLM code. This is a list of the changes I did:

  1. Added a README with a full set of instructions on how to install the repository from scratch
  2. Improved CMakeFiles.txt for a seamless compilation. There are still a couple steps that I would like to discuss with you, but now it's much better than before. You have to do less manual things and move less folders manually. I also added a FindTBB.cmake file because otherwise the TBB libraries were not found on a default Ubuntu installation.
  3. Restructured the folders in order to have a repository that is similar to every other ROS package out there.

Please review the changes, and merge the pull request if you like it! After this pull request will be closed, we can then move to do three things:

  1. Move the code as a public repo to the SAR organization, eventually renaming the repository with a more meaningful name (e.g. CLM_ros_wrapper or CLM_tracker_ros)
  2. Improve the codebase (for that I would like my students to work on it).
  3. Decide what to do with the CLM libs. It's quite cumbersome to have to manually place the libraries there and change their CMakeLists.txt. What do you think about this?
alecive commented 8 years ago

Regarding item number 3 on my todo list, we can also use git submodule if you so prefer. For me both options are ok!