After the first PR was approved, I went through and tidied up a whole bunch of checkstyle errors.
This included missing copyright headers, missing author tags/javadoc comments, unused imports and incorrect casings for variables.
This has now reduced the analysis report error count to 14 items.
There are only 5 priority 1 errors that are stopping this binding being compiled via mvn clean install. Those are all located in ThingLogger.java and are in relation to the inconsistent formatting when using the logger object. Refer to the Analysis Report in target/summary_report.html that generates when building code via mvn clean install.
After the first PR was approved, I went through and tidied up a whole bunch of checkstyle errors.
This included missing copyright headers, missing author tags/javadoc comments, unused imports and incorrect casings for variables.
This has now reduced the analysis report error count to 14 items.
There are only 5 priority 1 errors that are stopping this binding being compiled via
mvn clean install. Those are all located inThingLogger.javaand are in relation to the inconsistent formatting when using theloggerobject. Refer to the Analysis Report intarget/summary_report.htmlthat generates when building code viamvn clean install.Signed-off-by: Stewart Cossey stewart.cossey@gmail.com