search

themisir / form-validator

Simplest form validation for flutter form widgets
https://pub.dev/packages/form_validator
MIT License
77 stars 39 forks source link

form_validator v2.0.0 #34

Open themisir opened 2 years ago

themisir commented 2 years ago

I'm planning to release a major update for form_validator to "fix" or "improve" some issues on existing releases.

Here's some of goals I'm planning to improve on next version:

  1. Improving localization extensibility, preferably migrating with flutter localization kit, and supporting localization for custom validators also preferred - related issues: #7
  2. Providing more descriptive api for required and optional validation rules - related issues: #27 #29 #30
  3. Improving email validator. Currently afaik it does accepts emails like user@domain while that's accepted by specs, in real world use cases it's preferred to validate emails to have 2nd level domains. Preferably we can also make email validator customizable so users can use custom regexs for their use case - related issues: #26

If you're currently using form_validator and have any suggestions please let me know below, I'm currently no using this package myself so I'm not sure how else this could be improved further.

Also thanks for being involved in extending localization support and providing various feedbacks 😇

rikyscara commented 2 years ago

Hi @themisir thanks for this amazing extension. I just downloaded the form_validator extension in my project but it breaks as soon as I open the page that contains the form saying ArgumentError (Invalid argument (locale): Form validation locale is not yet supported.: "ja")

I'm trying to implement the Japanese language + validation and I found this Stack Overflow issue that is highlighting where the problem might lay. https://stackoverflow.com/questions/62540699/flutter-internationalization-for-japanese-failed

Thanks again for your extension.

My flutter doctor output

Doctor summary (to see all details, run flutter doctor -v): [✓] Flutter (Channel stable, 2.8.1, on macOS 12.1 21C52 darwin-x64, locale en-DE) [✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3) [✓] Xcode - develop for iOS and macOS (Xcode 13.2.1) [✓] Chrome - develop for the web [✓] Android Studio (version 4.2) [✓] VS Code (version 1.64.1) [✓] Connected device (2 available)

themisir commented 2 years ago

Hey @rikyscara , language code for Japanese is jp in form_validator. Is it supposed to be ja or jp? If it's wrong let me know I can change it.

rikyscara commented 2 years ago

Thanks a bunch for your prompt reply @themisir, I guess Flutter's default language code for Japanese language is ja. If you could change it it would be awesome 👍

rikyscara commented 2 years ago

Hey @themisir is a new minor version with the merged fix planned to release any time soon? Thanks again