search

themix-project / oomox-gtk-theme

Oomox-gtk-theme is a fork of Numix-gtk-theme with slightly different visual design choices and more customization capabilities. It can be used in Themix/Oomox app.
https://github.com/themix-project/oomox
GNU General Public License v3.0
42 stars 8 forks source link

Minor XFCE Arrow Visual Bug #11

Closed actionless closed 6 years ago

actionless commented 6 years ago

From @KUPOinyourWINDOW on November 19, 2017 16:12

screenshot_2017-11-19_16-10-38

When you open up a music player, then go into the XFCE sound menu (which is GTK3) the arrows that appear to scroll have an ugly white highlight colour. Thanks for your time and work!

Copied from original issue: actionless/oomox#108

actionless commented 6 years ago

does it have it only on hover or always?

ghost commented 6 years ago

Only on hover

actionless commented 6 years ago

i was trying Majaro XFCE vm recently (to make the recent xfce bugfixes) however i didn't found there that audio widget, what's the name of it's executable so i can install and run it? or mb the issue reproducing in some other places?

ghost commented 6 years ago

I'm not too sure as I don't have much experience with Manjaro (only installed it once, and the install didn't last long).

It's the one that comes standard in Xubuntu, but that's all I know :(

actionless commented 6 years ago

but can you see the same problem with any other app may be?

ghost commented 6 years ago

It's in all the GTK3 indicators with enough items to be scrollable

nana-4 commented 6 years ago

In gtk+ <=3.18, it's defined in .menuitem.button:hover: https://github.com/actionless/oomox-gtk-theme/blob/master/src/gtk-3.0/scss/widgets/_menu.scss#L129

In gtk+ >=3.20, it's defined in menu > arrow:hover: https://github.com/actionless/oomox-gtk-theme/blob/master/src/gtk-3.20/scss/widgets/_menu.scss#L173

I think this can be fixed by replacing mix($fg_color, $base_color, .1) to mix($menu_bg_color, $menu_fg_color, .1).

Or if you prefer normal menuitem colors, you can specify $selected_bg_color (and $selected_fg_color for color) like <=3.18 menu buttons. :)

actionless commented 6 years ago

@nana-4 thanks a lot!

hope now it should be fine