Change background color of column headers

[livanh]

In detailed column view, the headers get the same background color as the main area (BASE_COLOR): My impression is that they should have the same color as the window frame (BG_COLOR): Do you agree, or have any modifications to suggest?

[actionless]

on the screenshot you've provided it looks better however you need to do this to pass the tests: https://github.com/actionless/oomox-gtk-theme#generate-new-screenshots

see test log here: https://travis-ci.org/actionless/oomox-gtk-theme/builds/336244305#L2427

clearlooks gtk2-awf:
https://transfer.sh/Ly5yi/19-15-19_theme-clearlooks-gtk2-awf.test.png
https://transfer.sh/pUy7O/19-15-19_theme-clearlooks-gtk2-awf.orig.png
https://transfer.sh/Scvg4/19-15-19_theme-clearlooks-gtk2-awf.diff.png

[actionless]

so what is your opinion regarding using button style? https://github.com/actionless/oomox-gtk-theme/pull/19#discussion_r166766682

[livanh]

It's probably a good idea. If I can, I'll give it a try this evening (CET time). To be clear, are you referring to colors only, or also gradients/borsers/everything else?

[actionless]

that's good question, i think yes, inheriting button style could work much nicer

UPD: i've just checked both gtk2 and gtk3 code and they already inheriting the button

so just removing all the colors from column header style should do the trick

[livanh]

Button style: I like it. Shall we go with this one?

[actionless]

looks good on this preview! could you please generate the preview for other themes? so it will be easier to see how it works with dark, middle and light themes

[actionless]

thanks! on a light theme it looks already fine however on a medium and dark themes it's noticeable what border color is used from table cell, not button (i've made also inline comment on the commit):

https://raw.githubusercontent.com/livanh/oomox-gtk-theme/9723f903f8737a7bd34934b3465be02174dc6d22/screenshots/theme-monovedek_hidpi-gtk3-page3.png https://raw.githubusercontent.com/livanh/oomox-gtk-theme/9723f903f8737a7bd34934b3465be02174dc6d22/screenshots/theme-monovedek_lcars_hidpi-gtk3-page3.png

[actionless]

now i really like it! thank you for your hard work

[livanh]

I updated gtk+2 and the old version of gtk+3. I also made another small fix. The color of the path bar in the gtk+3 file selector was wrong IHMO (left is before, and right is after): Let me know if you agree.

[actionless]

so, for column headers — big 👍

[actionless]

thank you again for this great effort!

[livanh]

You're welcome!