themix-project / oomox-gtk-theme

Oomox-gtk-theme is a fork of Numix-gtk-theme with slightly different visual design choices and more customization capabilities. It can be used in Themix/Oomox app.
https://github.com/themix-project/oomox
GNU General Public License v3.0
46 stars 8 forks source link

Mate desktop icon names inactive highlight color wrong (invisible) #72

Open geckolinux opened 4 years ago

geckolinux commented 4 years ago

Hi, I'm using a custom oomox theme with Mate 1.24 on openSUSE Tumbleweed. Here's my gtk-3.20/dist/gtk.css file.

A problem I'm having is with the desktop icons, which become invisible when they are selected and then I focus on another window. For example, this is what I saw when trying to drag'n'drop the above CSS file into this issue editor:

Screenshot at 2020-07-14 07-48-57

Here's how highlighted text in an unfocused application normally looks (Simple Scan is focused):

Screenshot at 2020-07-14 07-53-23

I wonder how to change that without changing the main color of all the other applications? The color is #F7F7F7, and it appears all over the place, including in .gtkstyle-fallback.

Also, is this possibly related to #71 ?

actionless commented 4 years ago

I wonder how to change that without changing the main color of all the other applications?

use app-specific css selector, see in gtk inspector tree, usually it's the top one, or second from top, smth like MateDesktop

so final SCSS selector would be like

MateDesktop {
   .gtkstyle-fallback {
          foo: bar
    }
}

see https://github.com/themix-project/oomox-gtk-theme/blob/master/src/gtk-3.20/scss/apps/_mate-applications.scss

please send back the PR if you'll fix it on your side

Also, is this possibly related to #71 ?

not likely, but who knows

geckolinux commented 4 years ago

I finally found a fix that works in ~/.config/gtk-3.0/gtk.css

/* Fix Mate desktop selected icon background when unfocused */
.caja-desktop:selected {
background: #E95420;
}

Screenshot at 2020-08-05 10-47-07

Could this be integrated into the oomox generator for the global GTK theme?

I also tried background: @theme_bg_color; but it did not work, produced the same unreadable gray-on-gray that I posted in the original screenshot.

Thanks!

actionless commented 4 years ago

because in your theme theme_bg_color is gray, try selected_bg_color: https://github.com/themix-project/oomox-gtk-theme/blob/master/src/gtk-3.20/scss/_global.scss#L14

actionless commented 4 years ago

but to make those variables work, you'll need to edit https://github.com/themix-project/oomox-gtk-theme/blob/master/src/gtk-3.20/scss/apps/_mate-applications.scss as i mentioned above

geckolinux commented 4 years ago

@actionless Thanks for the reply. And how do I "compile" it after adjusting the .scss? (Sorry I don't know what the proper term is.)

actionless commented 4 years ago

just generate theme as normally