search

themix-project / oomox-gtk-theme

Oomox-gtk-theme is a fork of Numix-gtk-theme with slightly different visual design choices and more customization capabilities. It can be used in Themix/Oomox app.
https://github.com/themix-project/oomox
GNU General Public License v3.0
42 stars 8 forks source link

Missing (?) caret-color settings for generated themes #73

Open aphirst opened 3 years ago

aphirst commented 3 years ago

I've been very satisfied with oomox on my new setup, using my preferred and familiar numix brave theme.

I am however also a user of ibus for Japanese input, and it seems that the defaults for the oomox themes do not set all the necessary values. https://github.com/ibus/ibus/issues/1871#issuecomment-271918685

The accessibility overlay defaults to a black background, and with black text it obviously means you can't read the kanji selections.

If I manually set gtk-secondary-caret-color like in the linked thread to be the same color as, say, Selected Background (729fcf for shiki brave, for example), I get the desired behaviour (legible text).

Has this value been deliberately omitted in the generator?

actionless commented 3 years ago

do you mean those? 2020-09-22--1600729246_645x175_scrot

aphirst commented 3 years ago

I may mean those, yes! I am currently trying to work out, either from the code or from people in the ibus community, which properties are used for these dialogs, as there's another one (the emoji selector) that isn't helped by setting just the one parameter I mentioned in my OP. Sorry about the delay, but when problems lie at the intersection between unrelated projects, I figured it was best to gather that info before jumping any guns.

actionless commented 3 years ago

TBH i never used that feature of oomox theme myself, it was added by @cwendling here: https://github.com/themix-project/oomox/pull/69 mb he could help to debug this

cwendling commented 3 years ago

I'm not quite sure, but maybe that's a specific use case of IBus. I see that in my MR @actionless linked, I set the property on something more specific than *, so that might be the problem. I don't remember if there was a reason to do that apart that GTK only used it there (in views and entries), but I see 2 solutions: set it more globally, or make sure the IBus panel has the proper view class or so.