themoeway / yomitan

Japanese pop-up dictionary browser extension. Successor to Yomichan.
https://chromewebstore.google.com/detail/yomitan/likgccmbimhjbgkjambclfkhldnlhbnn
GNU General Public License v3.0
989 stars 76 forks source link

Empty popup shows on non-text elements when non-Japanese languages are selected #1011

Closed jamesmaa closed 1 month ago

jamesmaa commented 1 month ago

When hovering over certain non-text html, an empty popup with "No results found" shows up.

For example when I hover over the play button on Youtube

image

This does not occur when Japanese is selected.

Extension version: Yomitan 24.4.16.0 Platform: Mac OS Browser: Chrome Language: en-US User agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/125.0.0.0 Safari/537.36 AnkiConnect version: Unknown (Anki not running or connected) Installed dictionaries: Jitendex.org [2024-04-28]

Exported settings file known_buggy_yomitan_settings.json known_good_yomitan_settings.json

Related issues

Kajal-11 commented 1 month ago

I am trying to replicate this error in order to find a fix. Hovering over an image having no alt text, with English set as language in settings, I am getting a "No results found" popup. With Japanese settings, no popup shows up. Is this behavior also a consequence of the bug mentioned above?

Also, is the ideally expected behavior that this popup doesn't appear at all?

en settings

P.S.- It's on a Windows system.