search

themoeway / yomitan

Japanese pop-up dictionary browser extension. Successor to Yomichan.
https://chromewebstore.google.com/detail/yomitan/likgccmbimhjbgkjambclfkhldnlhbnn
GNU General Public License v3.0
989 stars 76 forks source link

Pitch accent dictionary is not linked from project page or dictionaries.md #1014

Closed lostfictions closed 1 month ago

lostfictions commented 1 month ago

Hi there, thanks for this project! I've been a happy user of Yomichan for a few years, so I'm glad to discover that the torch has been passed to new developers.

I'm setting up Yomitan with a fresh configuration (rather than importing anything from Yomichan). One hitch I ran into is that there don't seem to be any pitch accent dictionaries listed on the main project README or in dictionaries.md (as linked from the main README as "recommended dictionaries").

At first I wondered if pitch accent display was integrated somehow, since the README has a section mentioning the Kanjium license -- but I couldn't get pitch accent information to display at all.

Finally, I went to the Yomichan repo's Dictionaries section and grabbed kanjium_pitch_accents.zip and imported it. That fixed it!

If I had been a new user of Yomitan, I would simply have assumed that pitch accent display functionality was broken. Is there any reason kanjium_pitch_accents.zip or an equivalent isn't linked in dictionaries.md?

MarvNC commented 1 month ago

Removed: #227

lostfictions commented 1 month ago

@MarvNC Thanks for the response!

Am I to understand that there's no "legitimate" pitch accent support (via an alternative dictionary, say) for Yomitan now, then? Will it be removed as a feature?

MarvNC commented 1 month ago

The feature is supported, there just won't be any dictionaries linked in the docs.