search

themoeway / yomitan

Pop-up dictionary browser extension. Successor to Yomichan.
https://yomitan.wiki
GNU General Public License v3.0
1.12k stars 84 forks source link

Search terms when clicking text from the results list #1163

Open shiki-tm opened 2 months ago

shiki-tm commented 2 months ago

So this setting in yomitan exists here. But its actually annoying to use since its only 1 click to search for the word.

image

I have a feeling that almost nobody uses this setting because its inconvenient but i think it can be super useful for variant forms or for those who just dont want child popups! the way to make it easier to use in my opinion is if you change it to work with double click/double tap instead. then we wont have random searches.

There is just one issue with this and its the same that child popups have that i explained here in this issue: https://github.com/themoeway/yomitan/issues/902#issue-2288811142

Even though its a "new popup" when you create an anki flashcard it adds the sentence from within the previous popup dictionary entry. If this setting could be improved in these ways i will definitely be using this setting with both japanese and chinese

Kuuuube commented 1 month ago

Gave this a test and using this option also breaks theming so that will need to be fixed at some point too. This option also badly needs a description or a better name.