themoeway / yomitan

Pop-up dictionary browser extension. Successor to Yomichan.
https://yomitan.wiki
GNU General Public License v3.0
1.14k stars 88 forks source link

New Toggle option related standard keyboard shortcuts #1199

Open radonmiser opened 2 months ago

radonmiser commented 2 months ago

All of these are extensions of the current "Toggle option" hotkey, which takes path as input and flips the value when triggered.

  1. "set option value" Takes path and value as input, when pressed set a setting path to that value. Could be implemented a special case within 2. when only 1 value was provided.

  2. "cycle user defined option values" Takes path and 0, 1 or multiple values as input, when triggered cycle between the provided values. Could be implemented to cover 1. when only 1 value is provided. If no value is provided cycle through all default values for that setting. Use cases:

    • A user wishes to change sentence termination for anki notes depending on writer/books, the user only use 2 of all 4 options(for example Newlines only and Custom).
    • Quickly switch between result grouping modes
  3. "switch to a specific profile" Easy to access wrapper for 1. Use case:User can assign this to a less used profile.

  4. "cycle user defined profiles" Easy to access wrapper for 2. Use case:User has multiple profiles but only need to switch between 2 frequently.

Kuuuube commented 2 months ago

1 and 2 sound ridiculous to implement. 3 and 4 are for sure something we should have.