search

themoeway / yomitan

Pop-up dictionary browser extension. Successor to Yomichan.
https://yomitan.wiki
GNU General Public License v3.0
1.14k stars 88 forks source link

Right click "Lookup in Yomitan" popup does not work. #1276

Open ADG248 opened 1 month ago

ADG248 commented 1 month ago

Description (Describe what the issue is, if it is reproducible, and if possible, how to reproduce it.) Right click "Lookup in Yomitan" popup does not work. Steps: Right click on a word you want to lookup, click "Lookup in Yomitan" popup, nothing seems to happen.

Browser version Chrome: Version 127.0.6533.72 (Official Build) (64-bit)

Yomitan version Extension version: Yomitan 24.7.24.0

jamesmaa commented 1 month ago

Can you export and upload your yomitan settings? And post what dictionaries you have, you can find out in the question mark here

image
ADG248 commented 1 month ago

yomitan-settings-2024-07-28-04-39-15.json

I have installed the dictionaries in the screenshot. Screenshot 2024-07-28 004045

jamesmaa commented 1 month ago
image

hmm i'm not able to replicate with your settings when reading on ttsu

image

Does it not work on all websites or which websites have you tried using this on?

khaitruong922 commented 5 days ago

From what I have tested, Lookup in Yomitan does not work when selecting text on an input field, even if the text can be scanned through Shift key. The _getFirstSelectionRange() function does not return the range which contain the text.