search

themoeway / yomitan

Pop-up dictionary browser extension. Successor to Yomichan.
https://yomitan.wiki
GNU General Public License v3.0
1.19k stars 94 forks source link

Chinese: Update to the normalizer regex #1444

Open shiki-tm opened 1 week ago

shiki-tm commented 1 week ago

I see that there is already regex for 3 syllable separating symbols here https://github.com/themoeway/yomitan/pull/1215/commits/2456bba2d68f8296f21fcf632d04bcbcfa019e7d

Can these 3 also be added since they can be found in other dictionaries as well please? 2 different apostrophes and a kind of hyphen.

  1. "'"
  2. "’"
  3. "－"

Or should I just make a pull request?

Casheeew commented 1 week ago

You can go ahead and make a pull request. If possible, it'd be helpful if you can list out the dictionaries that use these separators in the PR description as well.