themoeway / yomitan

Japanese pop-up dictionary browser extension. Successor to Yomichan.
https://chromewebstore.google.com/detail/yomitan/likgccmbimhjbgkjambclfkhldnlhbnn
GNU General Public License v3.0
989 stars 76 forks source link

As of 23.11.12.0, certain custom CSS doesn't function properly anymore. #323

Closed Wyzmic closed 8 months ago

Wyzmic commented 8 months ago

The font size for the tag label contents does not go below 1em (default font size). It does function when increasing the value but not when decreasing it.

.tag-label-content {
   font-size: 0.5em;
}

Browser version Microsoft Edge 119.0.2151.58

Yomitan version 23.11.12.0

jbukl commented 8 months ago

can't replicate on my end - could you drop some settings/screenshots of the css?

Browser version Microsoft Edge 119.0.2151.58

Yomitan version 23.11.12.0 (clean install)

Wyzmic commented 8 months ago

I see, yeah sure. I've tried different fonts too and it's not that. I didn't change anything in particular either so I have no idea. image image image yomitan-settings-2023-11-15-15-31-33.json

jbukl commented 8 months ago

I see, yeah sure. I've tried different fonts too and it's not that. I didn't change anything in particular either so I have no idea. image image image yomitan-settings-2023-11-15-15-31-33.json

settings worked for me too - seems bizarre, as if a minimum value is being applied. have a few possible tests in mind:

  1. googling around made minimum font sizes sound odd - browsers apparently can set them though image does changing the setting on this page do anything?

  2. what does the dev tools show for .tag-label-content styles? is the custom css showing up?

image

  1. does disabling all of your dictionaries except for one change anything?

  2. any errors in dev tools console?

Wyzmic commented 8 months ago

The problem was the minimum font size, it's definitely a new setting. But now when I zoom in a page more than around 150%, even with the zoom level setting checked, the yomitan popup does scale with the browser zoom I'm using. Before when using em values for the font sizes, they stayed the same no matter what, now it's changed apparently. Maybe it's the newer browser code? Appreciate the help Jake!