themoeway / yomitan

Pop-up dictionary browser extension. Successor to Yomichan.
https://yomitan.wiki
GNU General Public License v3.0
1.2k stars 94 forks source link

Scrolling on Firefox mobile triggers popup despite settings #534

Closed pavliuk-ii closed 5 months ago

pavliuk-ii commented 8 months ago

Description I've been using kiwi+yomichan until recently, so I decided to migrate to yomitan and on top of that switch to firefox. There are two issues I currently have:

  1. If you set up scroll prevention inputs that used to work on old yomichan on yomitan, the popup stops showing up at all (configuration 1) (screenshot taken from https://github.com/KamWithK/AnkiconnectAndroid#instructions) I've tried changing settings a bit and found a configuration where it seems to work similarly (configuration 2), and it works well on kiwi, but here comes the second issue:
  2. When I use these settings on firefox, the popup still keeps appearing on scroll, despite "prevent touch scrolling" enabled. I suppose that it's the issue with how scrolling in firefox works, but is there any way to live with that? I can't read anything when once I scroll the screen a bit to advance with the text it throws a popup at me.

Browser version Kiwi Browser 120 / Firefox Mobile 121.1.0

Yomitan version 23.12.29.0

Exported settings file Two setting files, one for each input configuration: input settings.zip

djahandarie commented 8 months ago

Hmm, haven't looked into it yet, but it must be that Firefox Mobile is triggering different events :thinking: I wonder why...

Lyroxide commented 7 months ago

@djahandarie This issue occurs on Kiwi browser too. With KamWithK's settings on Yomitan 23.12.29.0, a single tap press would not trigger a pop-up, but a long press will (with text selected incorrectly, but the pop-up is correct). Using Yomitan 23.11.23.0, this issue does not occur. Seems like a regression occurred somewhere.

praschke commented 6 months ago

@pavliuk-ii "prevent touch scrolling" prevents cancelable touch move events from scrolling the view, it's not meant to prevent scanning.

i found a configuration using pointer inputs which improves over the emulated mouse in firefox android (on master).

Screenshot_20240315-220500 Screenshot_20240315-220405 Screenshot_20240315-220433

Kuuuube commented 5 months ago

Fixed in #791 with the new touchtap option.