themoeway / yomitan

Pop-up dictionary browser extension. Successor to Yomichan.
https://yomitan.wiki
GNU General Public License v3.0
1.12k stars 85 forks source link

Add an option to scan when selecting/highlighting text. #681

Closed mireimu closed 1 week ago

mireimu commented 6 months ago

Would be useful for touch users if there was an option to scan on highlighting text rather than on hover(tap).

brishtibheja commented 6 months ago

賛成です。アドオンの今の状態じゃスマホでスワイプするのはちょっと難しいかな。この機能があれば助かります。

Wyzmic commented 6 months ago

If you highlight text and yomitan pops up then you probably won't be able to copy any japanese text at all. Also these settings seem to work best, for me at least, could give it a shot. Screenshot_20240213_172314_Kiwi Browser.jpg

jamesmaa commented 1 week ago

This is done via #1028 and the keyboard shortcut Scan Selected Text

ActionBasto commented 1 week ago

This is done via #1028 and the keyboard shortcut Scan Selected Text

where do i find this option? sorry i'm not understanding.

MarvNC commented 1 week ago

I don't think this is done, mobile users can't use keyboard shortcuts easily. I believe the issue was asking for the popup to search on any text selection without keyboard input.

Kuuuube commented 1 week ago

jmaa almost certainly is referring to being able to select text and in the context menu scan with yomitan. Unfortunately, android browsers do not allow extensions to add things to the context menu due to the system context menu being the same as the one used in the browser.

As for scanning any time text is selected, that probably isnt a very good solution.

ActionBasto commented 1 week ago

i think there is a need for a more deliberate solution for yomitan on mobile. in it's current state the only 3 ideas that work for me are

a. turning it off until needed, which is very slow b. only enabling on specific sites, which isn't nearly as convenient when browsing casually or c. having a secondary browser with it enabled all the time

none of these solutions are great, but with it enabled normally it makes some sites near impossible to navigate with any settings i've tried.

MarvNC commented 1 week ago

As for scanning any time text is selected, that probably isnt a very good solution.

why? I would really like that as an option.