themoeway / yomitan

Japanese pop-up dictionary browser extension. Successor to Yomichan.
https://chromewebstore.google.com/detail/yomitan/likgccmbimhjbgkjambclfkhldnlhbnn
GNU General Public License v3.0
989 stars 76 forks source link

The `Sentence termination characters` setting doesn't work well #770

Closed BilderLoong closed 2 weeks ago

BilderLoong commented 4 months ago

Description (Describe what the issue is, if it is reproducible, and if possible, how to reproduce it.) I haven't configured the single quote as the sentence termination characters as the terminator. image But when I scan the word donc in this Des orages sont également fréquents durant l'été, il vaut donc mieux se munir d'un parapluie. The result {senetence} variable added into Anki is: été, il vaut donc mieux se munir d which only contain the part between two '.

Browser version I am using Chrome 122.0.6261.112 (Build officiel) (64 bits)

Yomitan version

Extension version: Yomitan (development build) 24.2.26.0
Platform: Windows
Browser: Chrome
Language: fr
User agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/122.0.0.0 Safari/537.36
AnkiConnect version: 6
Installed dictionaries: JMdict Extra, 研究社 新和英大辞典 第5版, BCCWJ-LUW, CC100, Youtube, 日本語文法辞典(全集), 絵でわかる日本語, 毎日のんびり日本語教師, どんなときどう使う 日本語表現文型辞典, JLPT文法解説まとめ, 語源由来辞典, Pixiv, デジタル大辞泉, 三省堂国語辞典 第八版, 大辞林 第四版, 実用日本語表現辞典, 岩波国語辞典 第八版, 広辞苑 第七版, 故事ことわざの辞典, 新明解国語辞典 第八版, 旺文社国語辞典 第十一版, 明鏡国語辞典 第二版, 複合語起源, アクセント辞典, kty-de-de-ipa, kty-de-de, kty-de-en-ipa, kty-de-fr-ipa, kty-de-fr, kty-de-ipa, kty-de-zh-ipa, kty-de-zh, kty-en-en-ipa, kty-en-fr-ipa, kty-en-fr, kty-en-zh-ipa, kty-en-zh, kty-fr-de-ipa, kty-fr-de, kty-fr-en-ipa, kty-fr-en, kty-fr-fr-ipa, kty-fr-fr, kty-fr-ipa, kty-fr-zh-ipa, kty-fr-zh, kty-ja-de-ipa, kty-ja-de, kty-ja-en-ipa, kty-ja-en, kty-ja-fr, kty-ja-ipa, kty-ja-zh-ipa, kty-ja-zh, kty-en-en, kty-en-de-ipa, kty-en-de, Jitendex.org [2024-02-25], Vicon Ger to Eng, yzk-freq-en-v3, yzk-freq-de-v3, kty-de-en, yzk-freq-fr-v3, Vicon Eng to Fre, Vicon Eng to Ger, Vicon Eng to Jp, Vicon Eng to Trad Chi, Vicon Fre to Eng, Wordset, seth-oald-extra, yzk-freq-en, seth-oald-ipa

Exported settings file (If you think it might be relevant, create a settings export file using the Export Settings button on the settings page and attach it to this issue.) You can use the フランス語 profile to reproduce this. yomitan-settings-2024-03-09-08-03-26.json

Do I misconfigure it, or is this a bug? If you need more information, please let me know.

StefanVukovic99 commented 4 months ago

It looks enabled by default, have you tried disabling it?

BilderLoong commented 4 months ago

It looks enabled by default, have you tried disabling it?

I tried disabling it like the below config: image

When scanning the word donc in the above example sentence, the result of the {sentence} is:

But when I scan the word donc in this Des orages sont également fréquents durant l'été, il vaut donc mieux se munir d'un parapluie.

This is the desired result. But why does the « won't break the sentence?

Kuuuube commented 2 weeks ago

This appears to be working as expected. If you want « to break the sentence you need to add it as a terminator not a quote.