search

themoeway / yomitan

Japanese pop-up dictionary browser extension. Successor to Yomichan.
https://chromewebstore.google.com/detail/yomitan/likgccmbimhjbgkjambclfkhldnlhbnn
GNU General Public License v3.0
989 stars 76 forks source link

Some Yomitan dictionaries aren't parsing correctly in the dev build but are in stable #807

Closed rotero08 closed 3 months ago

rotero08 commented 3 months ago

Description There's currently two recommended jmdict dictionaries in the shoui collection

  1. Jmdict extra, don't like it, too much examples and extra info I find useless 99% of the time (same with jitendex)
  2. Animecards compatible, for some reason I don't like compacted definitions, like: to guess; to predict; to read (someone's thoughts); to see (e.g. into someone's heart); to divine. I use a deprecated dictionay:
  3. Deprecated Jmdict (alternate) I like this one because it doesn't have the useless info and doesn't have compacted definitions so I use this one

I tried all 3 and with the first two it works fine, but in the third case it doesn't work in the dev build, but it does work as intended in the stable build.

The first two dictionaries the first option is most of the time the correct one (dev build): Jmdict extra: image image Jmdict animecards compatible: image image

But when I use the deprecated jmdict alternate (dev build) it looks like this: image image This second image can be fixed if I use CC100 as my sorting dic, but in any case in the stable build it works normally.

The thing is, when using the stable build, it parses them correctly: image image

I used the exact same dictionaries and settings in both.

Browser version Tried in both: Opera GX: LVL5 (core: 107.0.5045.86) Google Chrome: Version 123.0.6312.106 (Oficcial Build) (64 bits)

Yomitan version Yomitan (development build) 24.4.7.0

Exported settings file yomitan-settings-2024-04-07-18-51-06.json

Kuuuube commented 3 months ago

Fixed in #806.