search

themoeway / yomitan

Japanese pop-up dictionary browser extension. Successor to Yomichan.
https://chromewebstore.google.com/detail/yomitan/likgccmbimhjbgkjambclfkhldnlhbnn
GNU General Public License v3.0
989 stars 76 forks source link

Remove automatic update upon language switching #879

Open RyanOrigens opened 2 months ago

RyanOrigens commented 2 months ago

I would like to use Yomitan itself to scan text inside the Yomitan popup/window. Unfortunately, when you change the language, the popup automatically updates the dictionary info, so this use case doesn't work at the moment.

It would be great if this use case could be supported.

https://github.com/themoeway/yomitan/assets/103891807/924dd37a-aa5b-4423-8b99-1df1be67de01

StefanVukovic99 commented 2 months ago

image I think the profile conditions should let you scan your japanese popup with your english profile?

RyanOrigens commented 2 months ago

Oh, I wasn't aware of that. It seems like a very interesting feature. Unfortunately, though, it wouldn't work out. If I set the Chrome extension URL to scan English, I wouldn't be capable of scanning other Japanese text present in the example sentence. Additionally, I wouldn't be able to use the search bar with Japanese characters. The pop-up level wouldn't work either if I tried to scan Japanese text.

Example (I would be able to scan one or the other) image

StefanVukovic99 commented 2 months ago

I was thinking of the popup-level, though if you want to be able to scan the first popup with either profile, maybe you could just set them to different keys?

RyanOrigens commented 2 months ago

Yes, you're right. I could utilize another profile key. But let's imagine I'm in a different scenario where I also have a Korean-to-Japanese dictionary containing Korean and Japanese sentences in its example sentence. In that scenario, I would have to set one extra key to be able to scan this dictionary. Let's say my default is 'Super,' and then I would have to utilize another two key like 'Alt' and 'Shift.' You could argue that maybe it could be worked out with a preference order and stick with only two keys. But my point here is, don't you think other users may also come across this use case, and it would be too hacky of a solution? Perhaps there could be a better way?"

StefanVukovic99 commented 2 months ago

I see what you mean, the hotkeys don't cover such cases elegantly... Maybe there is a way to cover this without damaging other use cases, but I can't think of any.