themoeway / yomitan

Japanese pop-up dictionary browser extension. Successor to Yomichan.
https://chromewebstore.google.com/detail/yomitan/likgccmbimhjbgkjambclfkhldnlhbnn
GNU General Public License v3.0
977 stars 74 forks source link

Better Support for Switching Language Shortcut! #931

Open RyanOrigens opened 2 months ago

RyanOrigens commented 2 months ago

Currently, when trying to switch languages through the shortcut, you can only do so while the cursor is over the pop-up or the native window.

The problem arises when languages like "English," for example, are activated, and you are trying to scan Japanese text. You would need to manually switch before accessing the pop-up/window since English cannot scan Japanese text.

Solution:

Implement a global shortcut and add a pop-up notification to inform the user when the language has been switched, similar to an input method (keyboard).

image

MarvNC commented 2 months ago

If you aren't aware, you can change the profile through the extension browser popup menu by clicking the Yomitan icon.

RyanOrigens commented 2 months ago

Yeah, that's what I mean by changing manually, but if I always have to switch that way, it defeats the whole point of shortcuts.

JSchoreels commented 1 month ago

This comment is wrong, overlook from my side

Also the Anki Connect / Templates are not different from one profile to another one, which doesn't allow to add different langages/profiles in different decks _

Kuuuube commented 1 month ago

Also the Anki Connect / Templates are not different from one profile to another one, which doesn't allow to add different langages/profiles in different decks

This doesn't seem to be the case. It works perfectly fine for separating anki settings in my testing.

JSchoreels commented 1 month ago

Yep my bad. The settings were simply copied but indeed editing one doesn't edit the other. Sorry for the confusion, I'll edit first message

StefanVukovic99 commented 1 month ago

This works now, what's left is to add some UI to inform the user which profile he is now on.