search

themosis / framework

The Themosis framework core.
https://framework.themosis.com/
GNU General Public License v2.0
671 stars 121 forks source link

Include Entire Laravel Framework #806

Closed gagegogan closed 3 years ago

gagegogan commented 3 years ago

I've been having trouble integrating certain Laravel packages like InertiaJS and Ziggy due to the hard requirements that Themosis has on requiring Laravel. I'm suggesting that we remove the individual package requirements of individual Laravel packages and just require the entire framework. Additionally, I'm suggesting we upgrade ragonmantank/cron-expression to 3.0 (this is a Laravel 8 requirement). I've created a fork and did this. And I haven't noticed any problems. I also have a composer script to rename the Laravel __() function but I'm not sure where you would like me to place it.

ThinkDevStudios commented 3 years ago

I was also having the same problem before. One solution that I did before was to copy the laravel foundation directory to themosis. I was able to make it work but it was too much of a hassle to do so. I eventually found another solutions which already support Laravel 8. Its called Laraish. I was able to integrate inertia js with React. I do hope that Themosis will eventually have this feature because I still like the overall integration of Themosis to Wordpress compared to Laraish.

jlambe commented 3 years ago

We won't add the entire laravel framework into Themosis as is as foundation code is different. InertiaJS and other recent libraries working with Laravel are not compatible because current stable release of Themosis is targeting Illuminate package version 5.x where it needs at least version 7 or 8 to work.

The master branch is holding code to support Laravel 8.x so this should resolve normally on next release.

gagegogan commented 3 years ago

@jlambe I applied these changes too the master branch. There were no issues. There is no reason to my knowledge that should break it

gagegogan commented 3 years ago

Additionally the master branch will not support it because of the cron-express package being 2.0 not 3.0

jlambe commented 3 years ago

@armycoder What's the blocking part exactly ? Is it just upgrading the cron package ?

gagegogan commented 3 years ago

I believe so.

jlambe commented 3 years ago

I'll make sure to have the dependencies updated and then we'll test how InertiaJS behave with Themosis.