search

themosis / theme

The Themosis framework theme.
http://framework.themosis.com/
GNU General Public License v2.0
104 stars 35 forks source link

fix npm scripts for windows #35

Closed Jaspervv closed 5 years ago

Jaspervv commented 5 years ago

Most Windows command prompts will choke when you set environment variables with NODE_ENV=production like that.

cross-env makes it so you can have a single command without worrying about setting or using the environment variable properly for the platform.

read more about node-env here: https://www.npmjs.com/package/cross-env

Jaspervv commented 5 years ago

This was one of the issues I came across while setting up Themosis on Windows 10.

I realise now that this should have the bugfix/ prefix.

jlambe commented 5 years ago

I'll test this first but it should be a no brainer for merging I suppose.