search

themosis / theme

The Themosis framework theme.
http://framework.themosis.com/
GNU General Public License v2.0
104 stars 35 forks source link

Wrong config format sent to $theme->images #43

Closed danieldunderfelt closed 3 years ago

danieldunderfelt commented 3 years ago

I'm upgrading to Themosis 2.0 and ran into the following problem. In my new theme's functions.php there are three calls to $theme->* methods that have config values as arguments. But these config values are in an array under the key config, which the theme-> methods don't expect. For everything to work I have to send the values in ['config'] to the theme methods:

Screenshot 2021-04-18 at 8 57 08

The theme was created using the command from the upgrade guide: php console theme:install your-theme-name

danieldunderfelt commented 3 years ago

Ah, I figured it out! My config files were named like: theme.config.php and it split that into an array structure. This was a remnant from an old version of Themosis. Maybe it would be a good idea to mention this in the upgrade guide @jlambe?

jlambe commented 3 years ago

@danieldunderfelt I'll try to mention this as I'm focusing on next release but feel free to open a pull request on the themosis/documentation repository for the change ;)