search

themotte / rDrama

This code runs https://www.themotte.org. Forked from https://github.com/Aevann1/rDrama
GNU Affero General Public License v3.0
27 stars 31 forks source link

Allow ctrl-enter to submit posts. #243

Open zorbathut opened 2 years ago

zorbathut commented 2 years ago

See https://github.com/Aevann1/rDrama/blob/frost/files/assets/js/bootstrap.js#L5 - ours should not be under bootstrap.js, however. (warning: this page is an absolute terror to load due to the insanely long first line)

zorbathut commented 2 years ago

Note from Snakes:

ctrl-enter to submit is a much-loved UX feature, but it took a lot of commits to get right (because the IDs/classes on our input elements aren't terribly consistent), and the work on that is smeared over like 3 weeks of the commit log on the upstream. if anyone just naïvely ports that code in, make sure to test it in a lot of different contexts, because I think it took changes to the templates to make work.

so uh

there be dragons here