search

themotte / rDrama

This code runs https://www.themotte.org. Forked from https://github.com/Aevann1/rDrama
GNU Affero General Public License v3.0
25 stars 31 forks source link

remove unused badges #622

Closed justcool393 closed 1 year ago

justcool393 commented 1 year ago

starting some preliminary work on #610

zorbathut commented 1 year ago

Hrm, I have complicated feelings on this. I think this is a good change but I think the general badge setup is the wrong setup; we're doing this weird thing where we have a reference sql file that we replace a bunch manually. Shouldn't that data either be in Python or in the database, not in both?

I'd honestly be happy changing the badge-db part of this to

and that way we can also ignore downgrading and not be bothered making diffs for everything.

I guess let me know if you want to do that or if you'd rather just put this code in for now. Happy to just do this one for now :V

justcool393 commented 1 year ago

yeah i'm thinking in this case we can just nuke the badge table. it's not a terrible idea for our use case