search

themotte / rDrama

This code runs https://www.themotte.org. Forked from https://github.com/Aevann1/rDrama
GNU Affero General Public License v3.0
25 stars 31 forks source link

Refactor auth forms #624

Closed justcool393 closed 1 year ago

justcool393 commented 1 year ago

These forms are pretty terrible in every way, we copy and paste the markup multiple times for some unheard of reason. This kinda fixes that.

justcool393 commented 1 year ago

  • login/login.html doesn't extend authforms

    • login/sign_up.html doesn't extend authforms

    • login/reset_password.html doesn't exist: it's still reset_password.html, which needs to be moved into the "login" directory to match the others, and needs to extend the new authforms path. Also fix the indentation while moving it?

For testing the actual change, GET /forgot (login/forgot_password.html) is the easiest one to test the new authforms work on. It looks pretty good, but the vertical alignment of the form is off-center, and there's a white rectangle (ostensibly a navbar) at the top of the page.

fixed the white bar and other issues. the centering seems to be a non-regression at the very least but tbh i have no idea how to fix it

zorbathut commented 1 year ago

:+1: