search

themotte / rDrama

This code runs https://www.themotte.org. Forked from https://github.com/Aevann1/rDrama
GNU Affero General Public License v3.0
25 stars 30 forks source link

Make commenting the default #646

Closed justcool393 closed 1 year ago

justcool393 commented 1 year ago

fixes #314 and fixes #609

justcool393 commented 1 year ago

note hasn't been tested yet and I still need to do another pass on this. having some issues with some migrations making alembic unhappy so it may be a slight bit

justcool393 commented 1 year ago

still has some issues with saved comments/posts

justcool393 commented 1 year ago

ready for review

zorbathut commented 1 year ago

Request: Instead of changing userpage and userpage_comments into userpage_submissions and userpage, just switch 'em to userpage_submissions and userpage_comments. I don't think there's a good reason to promote one of those to being the base type, let's just have two variants.

(also it makes the diff kinda nightmarish)

Rest of it looks good! This was a boring and timeconsuming change, many thanks for doing it :)

zorbathut commented 1 year ago

Oh, nice, that's even cleaner than I was thinking.

Just waiting for unit tests and I'll check it in :)