Fix notifications from blocked users

themotte / rDrama

This code runs https://www.themotte.org. Forked from https://github.com/Aevann1/rDrama

GNU Affero General Public License v3.0

27 stars 31 forks source link

Fix notifications from blocked users #711

Closed wmill closed 1 year ago

wmill commented 1 year ago

Fix for #640

New notifications from blocked users were already blocked. This is for rendering of older notifications after the block happened.

zorbathut commented 1 year ago

That is a gnarly comments.html diff. I recognize most of it comes from correcting a whitespace error but it's kinda unreadable. Can you do one of:

Undo the whitespace fix, with my acknowledgement that it's wrong and should be fixed later
Send another pull request just with the whitespace fix and I'll get that one merged in first
Say "sorry, I don't have time for that right now, I apologize" and I'll go do it myself in a day or two :V

wmill commented 1 year ago

I'll do it

wmill commented 1 year ago

The comments.html change just displayed the block user status like in comments. Without it the notification just doesn't render so there's no real point to bothering with it.

zorbathut commented 1 year ago

Looks good! Many thanks, I'll go get this updated :D