New dark style for transparent header (menus and top navigation bar).

[ryanlabelle]

We've been talking about adding a dark style for the transparent header (per page). This is a good option when there is a light photo or light b/g colour and the white menu gets lost. We can put the option under the Page Settings tab.

[teaganm]

Sounds good. If this is a per-page option which would make the most sense, one thing to consider is how the logo is handled - right now we have users upload a logo and then there's an optional alternative logo for trans header - https://cl.ly/2U3M1c1R2A05 - if we go ahead with this it would make sense to change that.

We could perhaps instead have a dark logo and light logo upload - just want to make sure it's clear and not confusing.

[ryanlabelle]

• [x] Ship transparent header logo disabled.
• [x] Label the old transparent logo just "Alt Logo" ("used an option for trans logo")
• [x] New Option in Page Settings ( use alt logo ) Switch control.
• [x] New Option Header Content Style (Dark default, light) Select control.

[teaganm]

The styling has been added - still needs some tweaking but for the most part it's there.

So if the class "th-dark-tr" is added onto the header.banner and transparency is on, then the elements will appear dark instead of white.

[ryanlabelle]

Nice. I'll hop on this in the am.

[ryanlabelle]

Looking good. Just needs some testing.

[teaganm]

I think a recent change in Elementor caused this feature to stop working. It was looking good before, but when I test now I find that the class is not getting added so it's always white.

[ryanlabelle]

okay, this has been fixed but now I'm seeing an issue that didn't come up in testing before.

When using Theme Options / 'Enable Dark Style Header' with Page Settings / Transparent header on and Content Style = dark , the sticky nav top nav text is dark.

https://cl.ly/113l3R06111Z

[teaganm]

Ok yes I see that there was just a bit of code missing - it's now fixed 👍

I think we can consider this wrapped.