themovation / th-widget-pack

Theme Widget Pack
19 stars 6 forks source link

Tour edit page - grid image (optional) #138

Closed ryanlabelle closed 7 years ago

ryanlabelle commented 7 years ago
ryanlabelle commented 7 years ago

@teaganm take a look if you like. I think it's all working as per your request. Works much better.

teaganm commented 7 years ago

@ryanlabelle Thanks it works well and that section looks good in the backend now. Just a couple other points:

  1. After just doing a get latest I noticed that now the Intro text appears to be output as HTML instead of just the text: https://cl.ly/1Q0b0C2C1O0I

  2. While on the Edit Tour Single screen I noticed that by default 6 extra meta boxes are showing up that I don't see by default for Posts or Pages:

Here's what I see on the Edit screens of a brand new install:

Post: https://cl.ly/3H2F0H252j1o

Tour: https://cl.ly/0h1y0s1I020N

I know we were using the Excerpt in the previous framework, but now of course we're not and the others aren't needed either so it would be great if we could clean it up.

ryanlabelle commented 7 years ago

Good catch. All done.

teaganm commented 7 years ago

Great. (1) is looking good now.

For (2), I'm still seeing the extra meta boxes for some reason.

I tested deleting one of my sites, set up as new, copied the latest version of theme over, and after importing the demo content, they were there on the Tours.

Then I tried starting fresh without importing the content, and the first Tour I created also had the extra meta boxes.

ryanlabelle commented 7 years ago

I think that's because when you download a copy of the theme but it's not always the latest copy of the widget plugin. I just updated it to github. I just did a fresh install and I think we are good.

teaganm commented 7 years ago

Ah right, of course. Ok thanks looks good when I use the proper version!