search

themovation / th-widget-pack

Theme Widget Pack
19 stars 6 forks source link

Extra space at top of Blog template pages #147

Closed teaganm closed 7 years ago

teaganm commented 7 years ago

When using either the standard blog template or the masonry blog template, there is extra space at the top just below the page title - the space is from the output of the Content Editor section.

This issue didn't come up in our old framework b/c we didn't output the Content Editor on these templates - but now that Elementor is used for the page headers, we of course want to offer the option to have Content Editor content above the template output.

As we discussed, if we can make it so that the "content-editor" section is only output if there is content added (or if Elementor is enabled) that would be ideal. If that's not possible or is cumbersome to implement, then we can review and find a solution.

ryanlabelle commented 7 years ago

Hmm, I'll have to come back to this, I did a have_posts() which should be false but it returns true even when the the_content() is empty. Is there a quick workaround with CSS or is it hacky?

ryanlabelle commented 7 years ago

In addition to that, it looks like if I do a pre check for an empty page, Elementor won't work on that page. Strange. Let's talk about this tomorrow. Looks like we might need a css fix.

@teaganm

ryanlabelle commented 7 years ago

Adding .th-editor-empty class if content-editor element is empty, else just leave it as .content-editor.

teaganm commented 7 years ago

Great, thanks 👍