search

themovation / th-widget-pack

Theme Widget Pack
19 stars 6 forks source link

Thumbnail Slider Widget Template #43

Closed ryanlabelle closed 7 years ago

ryanlabelle commented 8 years ago

@teaganm I just added some sample php code for the Thumbnail Slider using Flexslider for @adiraomj can you add your markup?

https://github.com/ryanlabelle/themovation-so-widgets-bundle/commit/8e3f143a2484d577eae36e470b7a4b248fc892c5

teaganm commented 8 years ago

@ryanlabelle Can you have a look at the code I added temporarily into the Package widget? It's not yet working as expected. The element 'th-thumb-flex-slider' is supposed to wrap all the markup but it's closing right away instead. Looks like the JS is modifying the code to make it close instead.

ryanlabelle commented 8 years ago

Fixed. moved sample-id into the flexslider div and removed the empty sample-id div

adiraoco commented 8 years ago

I updated the template. I think @teaganm should add the HTML for the slides.

@ryanlabelle For this line, Instead of a unique number, I added a unique string. I'm guessing it's fine. Please confirm.

ryanlabelle commented 8 years ago

@adiraomj That's great. As long as it's unique we should be okay.