themovation / th-widget-pack

Theme Widget Pack
19 stars 6 forks source link

Portfolio widget #51

Closed teaganm closed 7 years ago

teaganm commented 8 years ago

@ryanlabelle The widget template file has a working example, but the filter bar isn't taking effect, and there are some extra classes as well. Let's review when possible.

ryanlabelle commented 8 years ago

All fixed. :)

teaganm commented 8 years ago

Alright @adiraomj it's now ready:

Included in the template file is a 4 column example, but they are all almost identical. Just a couple of class changes.

It will probably be helpful to have a look at the existing template for the portfolio - under /westwood/templates/portfolio-standard.php

If the filter bar is checked on, then output the #filters element, otherwise leave it out

For the number of columns - on the “th-portfolio-item” element:

And on the #th-portfolio-row element:

Lastly, the wrapper element #th-portfolio-content should have a unique ID, in the existing template it doesn’t but we’ll want that for the widget.

Let me know if you have any questions or comments.

adiraoco commented 8 years ago

What is the Order by - Drag and Drop option supposed to do?

teaganm commented 8 years ago

Currently that ties into a plugin that is included as recommended for our existing themes - Simple Page Ordering: https://wordpress.org/plugins/simple-page-ordering/

It adds the option for users to drag and drop custom post types to change the order. We can continue to use that, or we're open to another solution if you have an idea that would work better

adiraoco commented 8 years ago

That's cool. I just wanted to know how I should build the loop. Thanks. I'll get back to you if I have any problems.

teaganm commented 8 years ago

Sounds good Adi.

adiraoco commented 8 years ago

Hey. I think the fields to select the project icon and add a subheader have not been added yet. Please confirm. Thanks

adiraoco commented 8 years ago

@teaganm / @ryanlabelle please check my update and let me know if there is any problem with the logic of the loop.

ryanlabelle commented 8 years ago

Thanks @adiraomj looking good. A few things that I noticed.

https://en-ca.wordpress.org/plugins/simple-page-ordering/

I have some logic you might find helpful inside westwood/template/portfolio-standard.php

It has the logic for the filtering and drag and drop order.

Let me know if I can help. Other than that it's looking good. :)

adiraoco commented 8 years ago

Went through westwood/template/portfolio-standard.php. Thanks for that.

@teaganm Can you please have a look at the output of the widget. My code's output for the filter is the same as the HTML you added. However the filter does not seem to work. Can you please have a look and let me know what I am missing. Thanks.

@ryanlabelle I have fixed the issues with the Drag and Drop, and row options. Please have a look. Thanks.

Refer: https://github.com/ryanlabelle/themovation-so-widgets-bundle/tree/portfolio