search

themovation / th-widget-pack

Theme Widget Pack
19 stars 6 forks source link

Button Widget #57

Closed ryanlabelle closed 7 years ago

ryanlabelle commented 7 years ago

Hi Adi, we are hoping to make a change the the button widget which will affect other widgets as they embed the button widget in their forms.

We realize that several widgets embed the button widget and we think a two button widget is going to be commonplace so could we add the second button to the button widget and remove the second instance where it's embedded?

What we would end up with is a button widget that had two buttons, the second button being optional. That way when we embed it in other widgets it automatically has two buttons to use. We don't need to have two instances of the button widget anymore.

What we found is that we would like people to be able to use the button widget on it's own as well, and we think having two buttons inside the one widget is going to be necessary.

Sorry for the change. Is this possible?

Thank you.

adiraoco commented 7 years ago

Implemented in #70 Please test. Thanks

ryanlabelle commented 7 years ago

Looking great!

ryanlabelle commented 7 years ago

I think we can close this one too.