Updated button widget to new format

themovation / th-widget-pack

Theme Widget Pack

19 stars 6 forks source link

Updated button widget to new format #63

Open adiraoco opened 7 years ago

adiraoco commented 7 years ago

@ryanlabelle I have update the button as per #57. Please check the form structure and output. If you are fine with everything, I'll update all widgets using it as well.

A couple of notes:

The button 2 form is in its own section.
A user can choose to use both or any of the two buttons. A button is displayed if the Link URL field under the link child widget is not empty for the button.

ryanlabelle commented 7 years ago

Hi Adi, thanks. Everything looks good but the conditional logic is not working. Can you make it work just like the original button widget? The button type should show / hide certain fields.

Cheers!

adiraoco commented 7 years ago

I made a change in javascript file to accommodate for this. https://github.com/ryanlabelle/themovation-so-widgets-bundle/pull/63/files#diff-a0623ef93657e56554c5ddda522ed690R5 It seems to be working fine at my end. Can you please check if the javascript file is loading properly. Thanks

ryanlabelle commented 7 years ago

Thanks @adiraomj the form looks good on that branch. @teaganm do you have some updates to make to the template or do you think Adi has enough to go with?