search

themovation / th-widget-pack

Theme Widget Pack
19 stars 6 forks source link

Elementor Pricing Table Widget #73

Closed ryanlabelle closed 6 years ago

ryanlabelle commented 7 years ago

  1. @teaganm - Buttons need some default styling.

  2. Columns need to be hooked up the JavaScript to auto resize their hight. (FIXED)

@adiraomj - I have a js function inside the theme folder assests/js/main.js, called themo_adjust_pricing_table_height() it will auto adjust the height onload but it's not working in the frontend builder. Is there a trick to this?

I think that's all I see for now :)

adiraoco commented 7 years ago

Submitted a PR for westwood. I have updated the JS selectors to match our widgets. Please test it out and merge. :) https://github.com/ryanlabelle/westwood/pull/1/

ryanlabelle commented 7 years ago

Hi Adi, the selectors are updating on the frontend but I still don't see this updating in the live editor. Is there something I'm missing? I'm using the fixPricingJS branch.

ryanlabelle commented 7 years ago

Teagan has tried as well, works great the the live site but not in the builder.

adiraoco commented 7 years ago

For some reason the theme javascript files do not seem to be functioning. I think it has something to do with the way the files are enqueued. I'll try to find a fix.

ryanlabelle commented 7 years ago

Sounds good. Let us know when you are able to take a look. Cheers

adiraoco commented 7 years ago

My fix was not working after the settings were changed. Fixed it. Should be working smoothly now.

ryanlabelle commented 7 years ago

@teaganm can you try using the fixPricingJS branch? If I refresh elementor it adjusts the columns but while I'm building they are still uneven. I suppose this might not matter that much. Thoughts?

teaganm commented 7 years ago

Just tested this and I get the same results. If at all possible, it would be great if it worked while adding the content, but if it's going to be complicated and/or time consuming, it's not entirely crucial.

ryanlabelle commented 7 years ago

@adiraomj I wonder if this is something funky going on with the JS and elementor preview mode. I had a similar issue with the masonry script isotope , it works on the frontend but not the preview mode.

https://github.com/pojome/elementor/issues/1288

Do you think this is the same issue?

This one issue is not a big deal but it's part of a larger problem if they are related. We would like the preview mode to work when we are using javascript, this goes for the slider, blog masonry and everywhere else, like the pricing table. I created an issue with Elementor, but if you have any ideas that would be good to resolve. :)

adiraoco commented 7 years ago

Running the pricing height function along with the template. 8da0817f68a3e137afd4dea6a5c7aa5bb4b3df84

Please check. Thanks

ryanlabelle commented 7 years ago

And that works for you in preview mode?

ryanlabelle commented 7 years ago

If you try the blog widget can you see that the isotope masonry isn't working in preview mode either. I thought it was the same issue .

ryanlabelle commented 7 years ago

I'll test the pricing widget out with this update. Might do the same thing with isotope

ryanlabelle commented 7 years ago

Thanks. It works now, but themo_adjust_pricing_table_height() is already called in main.js when the windows loads and it loops through all pricing tables. So I'd rather not call it for each pricing table widget that's used. Is there another way?

ryanlabelle commented 7 years ago

I'm marking this as enhancement. No action required for now.