search

themovation / th-widget-pack

Theme Widget Pack
19 stars 6 forks source link

Button widget icon issue #81

Closed teaganm closed 7 years ago

teaganm commented 7 years ago

When I test icons in buttons, for the most part they’re looking good - https://cl.ly/3K2X1R2u2j3X

It's just that 4 icons near the top of the list don't appear in output - the ones that include address - https://cl.ly/2A1c0R0c3y2P

The same happens with Elementor buttons - https://cl.ly/2a0E1K0Q2p0k

I had a look and it seems to be a conflict with Booked which I know uses font awesome as well - just weird that it's only a few of the icons.

The icon actually does appear on page load / refresh, but then disappears - https://cl.ly/1s1Q2w2H1x0W

Are you getting the same results?

adiraoco commented 7 years ago

@teaganm I do not seem to be able to replicate the issue. Looks fine to me. The elementor widget looks fine too. screenshot-themo dev 2017-02-13 21-46-24

@ryanlabelle can you please check. Thanks.

ryanlabelle commented 7 years ago

@teaganm I see the issue you are talking about. I've tried several icons, most work, but address book and address card, flash and then disappear. @teaganm do you see the CSS that is causing the issue? Should we look at this together?

teaganm commented 7 years ago

@adiraomj the issue only comes up if the Booked plugin is activated since it seems to be a conflict there.

@ryanlabelle I'd looked at the CSS but it's not yet clear to to me. I'm thinking it has to do with the fact that Booked is currently including a different version of the icons than Elementor - but still not exactly obvious why some aren't working. Booked includes 4.6.3 and Elementor includes 4.7.0

The 500px icon works and it's included in both versions: https://cl.ly/373M1g2l0E0n

The address book icon does not work, and it is only listed in the new version: https://cl.ly/0d1x2F0F0q0D

So I checked and yes it looks like it's a new icon in FA 4.7: http://fontawesome.io/whats-new/

However I also had a look at other new icons such as the bandcamp icon, and it does work, but is also only listed in the new version: https://cl.ly/07403y232n1B

Looking at that What's New page on the FA site, some new ones work, some don't.

Also what I'm seeing in the Inspector is that when an icon is listed in both, the Elementor version (newer) is crossed out and the Booked version is used instead (older) perhaps if we change that it could solve it? It would be nice if we are not loading 2 versions of the icon library as well, but perhaps that's not a big deal.

adiraoco commented 7 years ago

Added a check to dequeue the Booked fa file if both the booked and elementor files are enqueued.

Please test. Thanks.

teaganm commented 7 years ago

Looks great, thanks Adi.