search

themovation / th-widget-pack

Theme Widget Pack
19 stars 6 forks source link

Blog Pagination Comments Showing #85

Closed ryanlabelle closed 7 years ago

ryanlabelle commented 7 years ago

@teaganm you mentioned a bug.

Bug: With the theme unit test added, on a page with the blog widget + pagination, when I go to page 2, the comments show up from the post “Template: Comments” underneath the masonry section - https://cl.ly/3L25453y061m

But, when I try I don't see this issue. Can you confirm your widget settings? Here is mine:

https://cl.ly/193P2c3Z3N1E

and also default:

https://cl.ly/0m3j1F2j3t0l

No comment overflow below prev / next

teaganm commented 7 years ago

My settings were this: https://cl.ly/2I1J2U1t463m - and in that case the comments showed up on page 2.

With the default settings: https://cl.ly/153u0g1x3w42 - then the issue appears for me on page 3

Same issue if I match my settings to your first screenshot.

I did a bit more testing though and what I have found is it seems the issue only happens if I have more than 42 blog posts published - up to and including 42 is fine, but once I have 43 then I see the issue on one of the pages. I had a few sample blog posts published before importing the unit test so that's why I had more than what it includes. If I have only the unit test + Hello World, then I do not see the issue.

Can you test with 43+ and see?

ryanlabelle commented 7 years ago

When I have 43+ I still don't see those comments showing up.

I've tried using a new page, with the blog widget, set it to the frontpage, comments and discussion on / off but I can't make them show. Strange. Let's try to review tomorrow and we'll see if our settings are the same.